| From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pending list clean up exposure to SQL |
| Date: | 2016-01-10 12:24:21 |
| Message-ID: | 56924D75.7060801@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29/12/2015 00:30, Jeff Janes wrote:
> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>>
>> I'll prepare a patch for core for the January commitfest, and see if
>> it flies. If not, there is always the extension to fall back to.
>
> Here is an updated patch. I've added type and permission checks,
> docs, and some regression tests.
>
I just reviewed it. Patch applies cleanly, everything works as intended,
including regression tests.
I think the function should be declared as strict.
Also, there are some trailing whitespaces in the documentation diff.
Regards.
> Cheers,
>
> Jeff
>
>
>
>
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-01-10 13:57:32 | Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix |
| Previous Message | David Rowley | 2016-01-10 10:17:56 | Re: Spelling corrections |