Re: Patch for migration of the pg_commit_ts directory

Hi.

Added a fatal message about an incorrect track_commit_timestamp parameter for new cluster.  Update test.


Fail check:




Checking for new cluster tablespace directories               ok


Checking for pg_commit_ts                                     


"track_commit_timestamp" must be "on" but is set to "off"


 

Successful:

Checking for new cluster tablespace directories               ok


Checking for pg_commit_ts                                     ok


...

----------------

Кому: Amit Kapila (amit(dot)kapila16(at)gmail(dot)com);

Копия: Hayato Kuroda (Fujitsu) (kuroda(dot)hayato(at)fujitsu(dot)com), pgsql-hackers(at)postgresql(dot)org;

Тема: Patch for migration of the pg_commit_ts directory;

06.10.2025, 12:59, "Maxim Orlov" <orlovmg(at)gmail(dot)com>:

 
 


On Thu, 2 Oct 2025 at 11:49, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:


 When we try to

copy slots and the wal_level on the new server is minimal, we error

out, so shouldn't we do the same here and error_out if

track_commit_timestamp is not enabled and we have some valid commit_ts

data to copy?


 


+1 Sounds reasonable to me. It's better to give an explicit error;

otherwise, we would remove data that the user clearly wants to migrate

to the new cluster. And deleting data just because the user forgot to

specify one parameter in a new cluster looks like a bad joke to me.   


 

--


Best regards,


Maxim Orlov.