Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Peter Geoghegan <pg(at)heroku(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates
Date: 2015-12-07 03:14:18
Message-ID: 5664F98A.3030107@proxel.se
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi,

I have reviewed this patch and it still applies to master, compiles and
passes the test suite.

I like the goal of the patch, making use of the already existing
abbreviation machinery in more cases is something we should do and the
patch itself looks clean.

I can also confirm the roughly 25% speedup in the best case (numerics
which are all distinct) with no measurable slowdown in the worst case.

Given this speedup and the small size of the patch I think we should
apply it. I will set this patch to "Ready for Commiter".

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2015-12-07 03:24:44 Re: Logical replication and multimaster
Previous Message Craig Ringer 2015-12-07 03:10:20 Re: pglogical_output - a general purpose logical decoding output plugin