| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
| Cc: | peter_e(at)gmx(dot)net, pgman(at)candle(dot)pha(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: SunOS patch for memcmp() |
| Date: | 2001-12-20 03:29:18 |
| Message-ID: | 5649.1008818958@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> Ok. I have tested patches from Bruce. Now tests for bit passed.
> Remaining issues seem that strtol() is broken on SunOS4, not detecting
> an overflow, which causes int4 and some of other tests failure.
Looks like you might also want to use horology-no-DST-before-1970.out.
> Should we use our own strtol()?
Mumble. The memcmp fix was all from well-tested parts, but I don't
think we have a canned test for strtol breakage available. Also,
I believe that the SunOS strtol lossage has been known and tolerated
in previous Postgres releases. Since it's not a regression, I'm going
to change sides and vote with Peter: let's not fix this one now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Lockhart | 2001-12-20 03:49:18 | datetime and timespan deprecated |
| Previous Message | Bruce Momjian | 2001-12-20 03:20:42 | Re: 7.2 is slow? [compile problem] |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2001-12-20 04:25:17 | Re: SunOS patch for memcmp() |
| Previous Message | Christopher Kings-Lynne | 2001-12-20 02:53:56 | Geometry patch for freebsd alpha |