| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: additional contrib test suites |
| Date: | 2017-09-18 13:54:52 |
| Message-ID: | 5645b0d7-cc40-6ab5-c553-292a91091ee7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/16/17 08:10, David Steele wrote:
>>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly
>>> designed, and too obsolete crypto-wise, to be useful or supportable.
>> crypt() uses the 7 lowest characters, which makes for 7.2e16 values,
>> so I would be fine with (5), then (4) as the test suite is not
>> portable.
> I'd prefer 5, but can go with 4.
>
> I get that users need to store their own passwords, but we have support
> for SHA1 via the crypto module which seems by far the better choice.
I'm also tempted to just remove it. It uses bad/outdated security
practices and it's also not ideal as an example module. Any objections?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-18 14:16:46 | Re: src/test/subscription/t/002_types.pl hanging on particular environment |
| Previous Message | Tom Lane | 2017-09-18 13:47:08 | Re: Reporting query on crash even if completed |