| From: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2025-10-15 16:59:01 |
| Message-ID: | 55e04bad-86ef-49cb-940e-3362c36eade6@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Jiah He!
1.
>please check the attach doc refactor for v62-0001.
Thanks for the changes, they look good (in translation).
2.
>here ereport should be elog(ERROR...).
>since this error should be unreachable. see check_nested_generated,
>cookDefault.
Changed.
3.
>"(as for LIKE and inheritances)":
>I think you meant, “CREATE TABLE LIKE and table inheritance reject
>whole-row check constraint, here we will do the same”.
>maybe change to ""(as for CREATE TABLE LIKE and inheritances)".
Changed.
--
With best regards,
Dmitry Koval
Postgres Professional: http://postgrespro.com
| Attachment | Content-Type | Size |
|---|---|---|
| v63-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch | text/plain | 169.8 KB |
| v63-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch | text/plain | 232.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-10-15 17:02:38 | Re: Adding basic NUMA awareness |
| Previous Message | Masahiko Sawada | 2025-10-15 16:20:03 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |