Re: Improving test coverage of extensions with pg_dump

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improving test coverage of extensions with pg_dump
Date: 2015-07-29 20:54:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I have reviewed this patch and it compiles runs and the new test case
passes. The code is also clean and the test seems like a useful
regression test.

What I do not like though is how the path src/test/tables_fk/t/ tells us
nothing about what features are of PostgreSQL are tested here. For this
I personally prefer the earlier versions where I think that was clear.

Another though: would it be worthwhile to also add an assertion to check
if the data really was restored properly or would that just be redundant


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2015-07-29 20:57:21 Re: more RLS oversights
Previous Message Merlin Moncure 2015-07-29 20:51:27 Re: dblink: add polymorphic functions.