Re: [BUGS] BUG #13126: table constraint loses its comment

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, xi(at)resolvent(dot)net, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #13126: table constraint loses its comment
Date: 2015-07-14 08:45:35
Message-ID: 55A4CC2F.8080401@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 07/14/2015 10:29 AM, Michael Paquier wrote:
> On Tue, Jul 14, 2015 at 1:42 AM, Heikki Linnakangas wrote:
>> I plan to commit the attached patches later today or tomorrow. But how do
>> you feel about back-patching this? It should be possible to backpatch,
>> although at a quick test it seems that there have been small changes to the
>> affected code in many versions, so it would require some work. Also, in
>> back-branches we'd need to put the new AT_ReAddComment type to the end of
>> the list, like we've done when we added AT_ReAddConstraint in 9.3. I'm
>> inclined to backpatch this to 9.5 only, even though this is clearly a bug
>> fix, on the grounds that it's not a very serious bug and there's always some
>> risk in backpatching.
>
> Well, while it's clearly a bug I don't think that it is worth the risk
> to destabilize back branches older than 9.5 in this code path. So +1
> for doing it the way you are suggesting. We could still revisit that
> later on if there are more complaints, but I doubt there will be much.

Ok, committed to master and 9.5. Thanks!

- Heikki

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeevan Chalke 2015-07-14 09:21:09 GSets: Fix bug involving GROUPING and HAVING together
Previous Message Michael Paquier 2015-07-14 07:33:26 Re: BUG #13490: Segmentation fault on pg_stat_activity

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2015-07-14 09:21:09 GSets: Fix bug involving GROUPING and HAVING together
Previous Message Heikki Linnakangas 2015-07-14 08:43:50 pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY