Re: Abbreviated keys for Numeric

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
Subject: Re: Abbreviated keys for Numeric
Date: 2015-04-04 20:37:52
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 04/04/2015 10:27 AM, Tom Lane wrote:
> Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Tom> ... btw, has anyone noticed that this patch broke hamerkop and
>> Tom> bowerbird? Or at least, it's hard to see what other recent commit
>> Tom> would explain the failures they're showing.
>> Now that Robert committed the fix for 64bit Datum w/o USE_FLOAT8_BYVAL,
>> bowerbird seems fixed (hamerkop hasn't run yet).
>> I see nothing in the win32 stuff that tries to define USE_FLOAT8_BYVAL
>> on 64-bit windows, is this just an oversight or does it not actually
>> work there? or is it for on-disk compatibility with 32-bit windows?
> That flag doesn't affect on-disk compatibility. It could certainly break
> third-party extensions, but we accept the same hazard on non-Windows with
> equanimity. I suspect this point simply wasn't revisited when we added
> support for 64-bit Windows.
> Having said that, I'm fine with leaving this as-is, if only because
> it means we're exercising the --disable-float8-byval code paths in
> the buildfarm ;-)

This seems quite wrong. If we want those paths tested we should ensure
that buildfarm members are set up with that explicit setting.

I think not making this the default for 64 bit MSVC builds was simply an
error of omission.

The attached patch should set float8byval as the default on 64 bit MSVC
builds and error out if it is explicitly set on 32 bit platforms.



Attachment Content-Type Size
win64float8byval.patch text/x-patch 1.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-04-04 20:40:53 Re: Abbreviated keys for Numeric
Previous Message Tomas Vondra 2015-04-04 20:29:58 Re: File count restriction of directory limits number of relations inside a database.