Re: Using 128-bit integers for sum, avg and statistics aggregates

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com>
Subject: Re: Using 128-bit integers for sum, avg and statistics aggregates
Date: 2015-03-15 23:37:08
Message-ID: 550617A4.8020502@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/15/2015 09:47 PM, Petr Jelinek wrote:
> It's almost the same thing as you wrote but the 128 bit and 64 bit
> optimizations are put on the same "level" of optimized routines.
>
> But this is nitpicking at this point, I am happy with the patch as it
> stands right now.

Do you think it is ready for committer?

New version with altered comment is attached.

--
Andreas Karlsson

Attachment Content-Type Size
int128-agg-v9.patch text/x-patch 38.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-03-15 23:38:19 Re: recovery_target_action = pause & hot_standby = off
Previous Message Tomas Vondra 2015-03-15 22:55:52 Re: PATCH: pgbench - merging transaction logs