Re: Optimization for updating foreign tables in Postgres FDW

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimization for updating foreign tables in Postgres FDW
Date: 2015-03-05 12:08:06
Message-ID: 54F84726.8070806@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2015/03/04 17:07, Etsuro Fujita wrote:
> On 2015/03/04 16:58, Albe Laurenz wrote:
>> Etsuro Fujita wrote:
>>> While updating the patch, I noticed that in the previous patch, there is
>>> a bug in pushing down parameterized UPDATE/DELETE queries; generic plans
>>> for such queries fail with a can't-happen error. I fixed the bug and
>>> tried to add the regression tests that execute the generic plans, but I
>>> couldn't because I can't figure out how to force generic plans. Is
>>> there any way to do that?
>>
>> I don't know about a way to force it, but if you run the statement six
>> times, it will probably switch to a generic plan.
>
> Yeah, I was just thinking running the statement six times in the
> regression tests ...

Here is an updated version. In this version, the bug has been fixed,
but any regression tests for that hasn't been added, because I'm not
sure that the above way is a good idea and don't have any other ideas.

The EXPLAIN output has also been improved as discussed in [1].

On top of this, I'll try to extend the join push-down patch to support a
pushed-down update on a join, though I'm still digesting the series of
patches.

Comments welcome.

Best regards,
Etsuro Fujita

[1] http://www.postgresql.org/message-id/31942.1410534785@sss.pgh.pa.us

Attachment Content-Type Size
postgres_fdw-update-v5.patch text/x-patch 66.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Syed, Rahila 2015-03-05 12:14:04 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Fujii Masao 2015-03-05 10:10:08 Re: Table-level log_autovacuum_min_duration