From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Redesigning checkpoint_segments |
Date: | 2015-02-13 17:43:14 |
Message-ID: | 54DE37B2.2080405@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02/04/2015 11:41 PM, Josh Berkus wrote:
> On 02/04/2015 12:06 PM, Robert Haas wrote:
>> On Wed, Feb 4, 2015 at 1:05 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>>> Let me push "max_wal_size" and "min_wal_size" again as our new parameter
>>> names, because:
>>>
>>> * does what it says on the tin
>>> * new user friendly
>>> * encourages people to express it in MB, not segments
>>> * very different from the old name, so people will know it works differently
>>
>> That's not bad. If we added a hard WAL limit in a future release, how
>> would that fit into this naming scheme?
>
> Well, first, nobody's at present proposing a patch to add a hard limit,
> so I'm reluctant to choose non-obvious names to avoid conflict with a
> feature nobody may ever write. There's a number of reasons a hard limit
> would be difficult and/or undesirable.
>
> If we did add one, I'd suggest calling it "wal_size_limit" or something
> similar. However, we're most likely to only implement the limit for
> archives, which means that it might acually be called
> "archive_buffer_limit" or something more to the point.
Ok, I don't hear any loud objections to min_wal_size and max_wal_size,
so let's go with that then.
Attached is a new version of this. It now comes in four patches. The
first three are just GUC-related preliminary work, the first of which I
posted on a separate thread today.
- Heikki
Attachment | Content-Type | Size |
---|---|---|
0001-Refactor-unit-conversions-code-in-guc.c.patch | application/x-patch | 13.4 KB |
0002-Renumber-GUC_-constants.patch | application/x-patch | 2.3 KB |
0003-Add-support-for-using-WAL-segments-as-GUC-base-unit.patch | application/x-patch | 2.0 KB |
0004-Replace-checkpoint_segments-with-min_wal_size-and-ma.patch | application/x-patch | 36.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-02-13 17:44:35 | Re: Refactoring GUC unit conversions |
Previous Message | Jim Nasby | 2015-02-13 17:34:36 | Re: Refactoring GUC unit conversions |