REVIEW: Track TRUNCATE via pgstat

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, <ash(at)commandprompt(dot)com>
Subject: REVIEW: Track TRUNCATE via pgstat
Date: 2014-12-16 00:30:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers (apologies for not replying to the thread; I can't find it in my inbox)

Patch applies and passes make check. Code formatting looks good.

The regression test partially tests this. It does not cover 2PC, nor does it test rolling back a subtransaction that contains a truncate. The latter actually doesn't work correctly.

The test also adds 2.5 seconds of forced pg_sleep. I think that's both bad and unnecessary. When I removed the sleeps I still saw times of less than 0.1 seconds. Also, wait_for_trunc_test_stats() should display something if it times out; otherwise you'll have a test failure and won't have any indication why.

I've attached a patch that adds logging on timeout and contains a test case that demonstrates the rollback to savepoint bug.
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble!

Attachment Content-Type Size
Show_broken_rollback_case.patch text/plain 1.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-12-16 00:32:53 Re: pg_rewind in contrib
Previous Message Jeff Janes 2014-12-16 00:22:59 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}