Spurious set in heap_prune_chain()

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Spurious set in heap_prune_chain()
Date: 2014-10-21 22:51:08
Message-ID: 5446E35C.9060208@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

In heap_prune_chain():

tup.t_tableOid = RelationGetRelid(relation);

rootlp = PageGetItemId(dp, rootoffnum);

* If it's a heap-only tuple, then it is not the start of a HOT chain.
if (ItemIdIsNormal(rootlp))
htup = (HeapTupleHeader) PageGetItem(dp, rootlp);

tup.t_data = htup;
tup.t_len = ItemIdGetLength(rootlp);
tup.t_tableOid = RelationGetRelid(relation);

AFAICT the second case of setting tup.t_tableOid is pointless. Attached patch removes it. Passes make check.
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

Attachment Content-Type Size
patch text/plain 527 bytes

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-10-21 23:00:07 Re: Proposal: Log inability to lock pages during vacuum
Previous Message Alvaro Herrera 2014-10-21 22:39:48 Re: Proposal: Log inability to lock pages during vacuum