Re: A question about code in DefineRelation()

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: A question about code in DefineRelation()
Date: 2014-04-22 09:30:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(2014/04/04 13:35), Etsuro Fujita wrote:
> If I understand correctly, foreign tables cannot have an OID column, but
> the following code in DefineRelation() assumes that foreign tables *can*
> have that coulum:

On second thought I noticed that that makes CREATE FOREIGN TABLE include
an OID column in newly-created foreign tables wrongly, when the
default_with_oids parameter is set to on. Please find attached a patch.


Best regards,
Etsuro Fujita

Attachment Content-Type Size
DefineRelation.patch text/plain 676 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jov 2014-04-22 09:42:37 Re: AXLE Plans for 9.5 and 9.6
Previous Message Hannu Krosing 2014-04-22 09:03:22 Re: Clock sweep not caching enough B-Tree leaf pages?