| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | gkokolatos(at)pm(dot)me, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-02-19 17:10:13 |
| Message-ID: | 535565cd-b69f-c064-a845-15c0fc44db4a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Georgios,
I spent some time looking at the patch again, and IMO it's RFC. But I
need some help with the commit messages - I updated 0001 and 0002 but I
wasn't quite sure what some of the stuff meant to say and/or it seemed
maybe coming from an earlier patch version and obsolete.
Could you go over them and check if I got it right? Also feel free to
update the list of reviewers (I compiled that from substantial reviews
on the thread).
The 0003 commit message seems somewhat confusing - I added some XXX
lines asking about unclear stuff.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Prepare-pg_dump-internals-for-additional-compres-v29.patch | text/x-patch | 15.0 KB |
| 0002-Introduce-a-generic-pg_dump-compression-API-v29.patch | text/x-patch | 69.6 KB |
| 0003-Add-LZ4-compression-to-pg_dump-v29.patch | text/x-patch | 30.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-19 19:01:13 | Re: wrong query result due to wang plan |
| Previous Message | Tom Lane | 2023-02-19 16:13:38 | Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c |