Re: Split xlog.c

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Split xlog.c
Date: 2022-01-25 10:12:40
Message-ID: 52bc9ccd-8591-431b-0086-15d9acf25a3f@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17/12/2021 13:10, Heikki Linnakangas wrote:
> I think this is ready for commit now. I'm going to wait a day or two to
> give everyone a chance to review these latest changes, and then push.

In last round of review, I spotted one bug: I had mixed up the meaning
of EndOfLogTLI. It is the TLI in the *filename* of the WAL segment that
we read the last record from, which can be different from the TLI that
the last record is actually on. All existing tests were passing with
that bug, so I added a test case to cover that case.

So here's one more set of patches with that fixed, which I plan to
commit shortly.

- Heikki

Attachment Content-Type Size
v10-0005-Split-xlog.c-into-xlog.c-and-xlogrecovery.c.patch text/x-patch 326.6 KB
v10-0004-Move-code-around-in-StartupXLOG.patch text/x-patch 25.7 KB
v10-0003-Refactor-setting-XLP_FIRST_IS_OVERWRITE_CONTRECO.patch text/x-patch 5.3 KB
v10-0002-Run-pgindent-on-xlog.c.patch text/x-patch 9.2 KB
v10-0001-Add-test-case-for-an-archive-recovery-corner-cas.patch text/x-patch 7.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-01-25 10:19:58 Re: [PATCH] Allow multiple recursive self-references
Previous Message Julien Rouhaud 2022-01-25 10:08:02 Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements