Re: Error code returned by lock_timeout

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: Error code returned by lock_timeout
Date: 2013-06-27 15:12:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

2013-06-27 17:03 keltezéssel, Fujii Masao írta:
> On Thu, Jun 27, 2013 at 2:22 PM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>> Hi,
>> I just realized that in the original incarnation of lock_timeout,
>> I used ERRCODE_LOCK_NOT_AVAILABLE (to be consistent with NOWAIT)
>> but the patch that was accepted into 9.3 contained ERRCODE_QUERY_CANCELED
>> which is the same as for statement_timeout.
>> Which would be more correct?
> ISTM that ERRCODE_LOCK_NOT_AVAILABLE is more suitable...

I think, too. Can someone commit this one-liner to master and 9.3?

Best regards,
Zoltán Bsöszörményi

Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria

Attachment Content-Type Size
lock_timeout-errcode-fix.patch text/x-patch 443 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-06-27 15:29:46 Re: [PATCH] add --progress option to pgbench (submission 3)
Previous Message Robert Haas 2013-06-27 15:08:59 Re: Improvement of checkpoint IO scheduler for stable transaction responses