| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, hlinnakanga(at)awork2(dot)anarazel(dot)de, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Slave enters in recovery and promotes when WAL stream with master is cut + delay master/slave |
| Date: | 2013-01-17 15:18:14 |
| Message-ID: | 50F81636.6000701@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.01.2013 15:05, Andres Freund wrote:
> On 2013-01-17 13:47:41 +0900, Michael Paquier wrote:
>> I think that bug has been introduced by commit 7fcbf6a.
>> Before splitting xlog reading as a separate facility things worked
>> correctly.
>> There are also no delay problems before this commit.
>
> Ok, my inkling proved to be correct, its two related issues:
>
> a ) The error handling in XLogReadRecord is inconsistent, it doesn't
> always reset the necessary things.
>
> b) ReadRecord: We cannot not break out of the retry loop in readRecord
> just so, just removing the break seems correct.
>
> c) ReadRecord: (minor): We should log an error even if errormsg is not
> set, otherwise we wont jump out far enough.
>
> I think at least a) and b) is the result of merges between development
> of different people, sorry for that.
Got a patch?
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-01-17 15:19:23 | Re: Hot Standby conflict resolution handling |
| Previous Message | Heikki Linnakangas | 2013-01-17 15:14:04 | Re: Removing PD_ALL_VISIBLE |