Re: PATCH: optimized DROP of multiple tables within a transaction

From: Tomas Vondra <tv(at)fuzzy(dot)cz>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: optimized DROP of multiple tables within a transaction
Date: 2013-01-08 21:38:52
Message-ID: 50EC91EC.6030903@fuzzy.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8.1.2013 22:30, Alvaro Herrera wrote:
> Tomas Vondra wrote:
>> On 8.1.2013 03:47, Shigeru Hanada wrote:
>
>>>>> * +1 for Alvaro's suggestion about avoiding palloc traffic by starting
>>>>> with 8 elements or so.
>>>>
>>>> Done.
>>>
>>> Not yet. Initial size of srels array is still 1 element.
>>
>> I've checked the patch and I see there 'maxrels = 8' - or do you mean
>> something else?
>
> Well, you need to ensure that the initial palloc is an array of that
> size.

Oh, right - I forgot to modify the palloc() call. Thanks for spotting
this. Attached is a patch with increased threshold and fixed palloc call.

Tomas

Attachment Content-Type Size
drop-in-transaction-v8.patch text/x-diff 8.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-01-08 21:51:25 Re: Weird Assert failure in GetLockStatusData()
Previous Message Merlin Moncure 2013-01-08 21:32:46 Re: json api WIP patch