From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org, Jeremy Drake <pgbuildfarm(at)jdrake(dot)com> |
Subject: | Re: [HACKERS] pgsql: Refactor flex and bison make rules |
Date: | 2012-11-28 23:29:56 |
Message-ID: | 50B69E74.5040702@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 11/28/2012 06:19 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 11/28/12 6:01 PM, Tom Lane wrote:
>>> I wonder whether adding another .NOTPARALLEL directive would be a better
>>> idea than insisting people get hold of patched versions.
>> We could put
>> ifeq ($(MAKE_VERSION),3.82)
>> .NOTPARALLEL:
>> endif
>> into Makefile.global.
> I don't wish to go *that* far. Parallel make works fine for most of the
> tree in 3.82, and shutting it off would penalize developers a lot.
>
> It appears to me that the case that okapi is hitting is specific to the
> ecpg preprocessor build rules, and indeed specific to the case where
> preproc.c needs to be rebuilt. A .NOTPARALLEL in ecpg/preproc/Makefile
> would probably be enough to fix it. (I'm a bit tempted to make the one
> already added to ecpg/Makefile conditional on the make version, as you
> suggest above, too.)
>
>
There is something odd about okapi, because my linux/gcc buildfarm
animal is using make 3.82 happily, with make_jobs = 4.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-11-28 23:49:52 | Re: [HACKERS] pgsql: Refactor flex and bison make rules |
Previous Message | Tom Lane | 2012-11-28 23:19:31 | Re: [COMMITTERS] pgsql: Refactor flex and bison make rules |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-11-28 23:41:39 | Re: Bugs in CREATE/DROP INDEX CONCURRENTLY |
Previous Message | Tom Lane | 2012-11-28 23:19:31 | Re: [COMMITTERS] pgsql: Refactor flex and bison make rules |