Skip site navigation (1) Skip section navigation (2)

Re: PATCH: pgbench - random sampling of transaction written into log

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Tomas Vondra <tv(at)fuzzy(dot)cz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: pgbench - random sampling of transaction written into log
Date: 2012-10-03 12:49:31
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On 03.09.2012 01:40, Tomas Vondra wrote:
> So, here is a fixed version of the patch. I've made these changes:

Committed with some minor kibitzing.

> 1) The option is now '--sampling-rate' instead of '-R' and accepts float
> arguments. I've decided not to use 0.01 = 1% but use 1 = 1%, so it
> accepts values between 0 and 100. I find this more natural.

I find a fraction, ie. 0.01 = 1% more natural, so I changed it back to 
that. I realize this is bike-shedding, but I believe Robert also found 
this more natural, as that's what he suggested upthread.

I edited the comments and variable names a little bit, and also added a 
small paragraph to the pgbench user manual about this under 
"Per-Transaction Logging", in addition to the explanation under 
"Benchmarking Options"

- Heikki

In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2012-10-03 12:55:37
Previous:From: Boszormenyi ZoltanDate: 2012-10-03 12:38:05
Subject: Re: [PATCH] Make pg_basebackup configure and start standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group