| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ICU locale validation / canonicalization |
| Date: | 2023-02-28 05:57:26 |
| Message-ID: | 4eebea80f528b1b5e381d6e834497bd6983e4e93.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2023-02-20 at 15:23 -0800, Jeff Davis wrote:
>
> New patch attached. The new patch also includes a GUC that (when
> enabled) validates that the collator is actually found.
New patch attached.
Now it always preserves the exact locale string during pg_upgrade, and
does not attempt to canonicalize it. Before it was trying to be clever
by determining if the language tag was finding the same collator as the
original string -- I didn't find a problem with that, but it just
seemed a bit too clever. So, only newly-created locales and databases
have the ICU locale string canonicalized to a language tag.
Also, I added a SQL function pg_icu_language_tag() that can convert
locale strings to language tags, and check whether they exist or not.
--
Jeff Davis
PostgreSQL Contributor Team - AWS
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-ICU-locale-string-canonicalization-and-validation.patch | text/x-patch | 26.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-02-28 06:15:38 | Re: Make some xlogreader messages more accurate |
| Previous Message | Bharath Rupireddy | 2023-02-28 05:42:29 | Re: Track Oldest Initialized WAL Buffer Page |