| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: partition tree inspection functions |
| Date: | 2018-10-30 01:53:43 |
| Message-ID: | 4eaf3516-49e5-f963-e137-3d63a3ca3fa6@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/10/30 10:33, Michael Paquier wrote:
> Thanks for the new version and using better index names. I have
> reviewed and committed the patch, with a couple of things tweaked:
> - removal of the tests on the size, they don't seem useful as part of
> showing partition information.
> - no need to join on pg_class for the test of the normal table.
> - added some comments and reformulated some other comments.
> - added a test with a materialized view.
> - added a test with a NULL input (as that's a strict function).
Thank you!
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-30 02:39:31 | Re: Conflicting option checking in pg_restore |
| Previous Message | Tatsuo Ishii | 2018-10-30 01:36:54 | pgbench doc fix |