| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | zengman <zengman(at)halodbtech(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speed up ICU case conversion by using ucasemap_utf8To*() |
| Date: | 2025-12-31 15:40:31 |
| Message-ID: | 4cfde442-25dd-495f-8d76-a23502ce17b8@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/31/25 3:36 AM, zengman wrote:
> On the mailing list, I've noticed this patch. I tested its functionality and it works really well. I have a few minor, non-critical comments to share.
Thanks for trying it out!
> In the `pg_ucasemap_open` function, the error message `casemap lookup failed:` doesn't seem ideal. This is because we're opening the `UCaseMap` here, rather than performing a "lookup" operation.
Fixed.
> In the comment `Additional makes sure we get the right options for case folding.`, the word Additional seems inappropriate — `Additionally` would be a better replacement.
Fixed.
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Use-optimized-versions-of-ICU-case-conversion-for.patch | text/x-patch | 13.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2025-12-31 15:48:00 | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |
| Previous Message | Tom Lane | 2025-12-31 15:26:44 | Re: Add "format" target to make and ninja to run pgindent and pgperltidy |