| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: base backup client as auxiliary backend process |
| Date: | 2020-01-11 09:52:30 |
| Message-ID: | 4c79f835-b443-7b02-9097-aa1a40f46be9@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-01-10 04:32, Masahiko Sawada wrote:
> I agreed that these patches are useful on its own and 0001 patch and
committed 0001
> 0002 patch look good to me. For 0003 patch,
>
> + linkend="guc-primary-slot-name"/>. Otherwise, the WAL receiver may use
> + a temporary replication slot (determined by <xref
> + linkend="guc-wal-receiver-create-temp-slot"/>), but these are not shown
> + here.
>
> I think it's better to show the temporary slot name on
> pg_stat_wal_receiver view. Otherwise user would have no idea about
> what wal receiver is using the temporary slot.
Makes sense. It makes the code a bit more fiddly, but it seems worth
it. New patches attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Expose-PQbackendPID-through-walreceiver-API.patch | text/plain | 3.1 KB |
| v2-0002-walreceiver-uses-a-temporary-replication-slot-by-.patch | text/plain | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Artur Zakirov | 2020-01-11 10:04:50 | Re: Add pg_file_sync() to adminpack |
| Previous Message | Kohei KaiGai | 2020-01-11 08:07:11 | Re: How to retain lesser paths at add_path()? |