Re: Hung JDBC connections

On 06/11/2012 11:02 PM, Mike Charnoky wrote:
>
> On 06/09/2012 11:39 PM, Craig Ringer wrote:
>>
>> Of course, It's not very friendly for the JDBC driver to wait
>> indefinitely without periodically checking and seeing if the
>> connection was progressing, so I'm glad to see that's changed in 9.1.
>>
> I took a look at the 9.1 JDBC driver source code, very enlightening. I
> see that Statement.setQueryTimeout() doesn't actually do anything! The
> method sets a member variable which is never accessed locally or by
> any subclasses or via getQueryTimeout(). There is even the following
> comment in AbstractJdbc2Statement:
> /** Timeout (in seconds) for a query (not used) */
> protected int timeout = 0;
>
> I see that ConnectionFactoryImpl does allow the underlying Socket's
> so_timeout and so_keepalive options to be set using the connection
> parameters string:
> http://jdbc.postgresql.org/documentation/91/connect.html
> (socketTimeout and tcpKeepAlive). Didn't realize these options
> existed, I will definitely be taking advantage of these.
>
> However, I see these options were available as far back as 8.4. What
> exactly are these driver changes in 9.1 that you mentioned???

Sorry, as Dave points out, 9.2.

--
Craig Ringer