Skip site navigation (1) Skip section navigation (2)

Re: "make check" in src/test/isolation is unworkable

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: "make check" in src/test/isolation is unworkable
Date: 2012-02-29 20:08:06
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers

On 02/29/2012 02:33 PM, Peter Eisentraut wrote:
> On sön, 2011-05-08 at 19:35 -0400, Tom Lane wrote:
>> I believe that the "make check" target in src/test/isolation is
>> fundamentally unportable, as is illustrated by the fact that buildfarm
>> member coypu is currently choking on it.  The reason is that the
>> pg_isolation_regress program depends on libpq, and in particular it
>> depends on having an *installed* libpq.  Anyplace where it appears to
>> work, it's because you already installed Postgres, or at least libpq.
> I came across this old issue.  Unless I'm missing something, there is no
> reason why pg_isolation_regress needs to be linked with libpq at all,
> and it works fine without it.  If we removed the libpq link, then it
> would work just like pg_regress and could support "make check".
> Apparently, -Wl,--as-needed isn't working too well here.

I believe we can't rely on it working. If we really don't need libpq 
then why not just filter it out?



In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2012-02-29 20:14:14
Subject: Re: 16-bit page checksums for 9.2
Previous:From: Peter EisentrautDate: 2012-02-29 19:36:16
Subject: Re: controlling the location of server-side SSL files

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group