Re: FDW system columns

From: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Thom Brown <thom(at)linux(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FDW system columns
Date: 2012-02-29 05:24:43
Message-ID: 4F4DB69B.3030307@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2012/02/28 23:37), Kohei KaiGai wrote:
> 2012年2月28日12:00 Shigeru Hanada<shigeru(dot)hanada(at)gmail(dot)com>:
>> We have three options:
>>
>> a) remove all system columns (posted patch)
>> b) remove system columns other than tableoid
>> c) leave all system columns as is (current 9.2dev)
>>
>> Incidentally, views, which is very similar object type to foreign
>> tables, have no system columns.
>>
>> Thoughts?
>>
> Which is the expected behavior in case of a foreign table
> is constructed as a child table of a particular regular table?
> In this case, children foreign tables don't have columns
> that exist on the parent table?
> (Although it is no matter when a regular table is a child of
> a foreign table...)

If we support table inheritance by foreign tables, foreign tables should
return something for all system columns, because a child table MUST have
all columns held by all parent tables. I'm not sure that foreign tables
should have system columns physically, like the option c).

For now, c) seems most reasonable to me.

--
Shigeru Hanada

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-02-29 08:18:05 Re: Parameterized-path cost comparisons need some work
Previous Message Alvaro Herrera 2012-02-29 03:28:14 Re: a typo in json.h