Re: Re: pgAdmin III commit: Fix constraints handling on the table properties di

From: Erwin Brandstetter <brsaweda(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: Re: pgAdmin III commit: Fix constraints handling on the table properties di
Date: 2012-02-27 15:54:42
Message-ID: 4F4BA742.7070309@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On 19.12.2011 14:07, Guillaume Lelarge wrote:
> On Mon, 2011-12-19 at 03:42 -0800, Erwin Brandstetter wrote:
>> On Dec 10, 11:46 am, guilla(dot)(dot)(dot)(at)lelarge(dot)info (Guillaume Lelarge) wrote:
>>> Fix constraints handling on the table properties dialog
>>>
>>> The wxListCtrl control doesn't handle strings or more than 512 characters on
>>> Windows. So we need to put the definition of constraints in a wxArrayString so
>>> that we won't have issues on the size of the constraint's definition.
>>>
>>> Report from Vjacheslav Vjacheslav.
>>> Some help from Julius Tuskenis.
>>>
>>> Branch
>>> ------
>>> REL-1_14_0_PATCHES
>>>
>>> Details
>>> -------http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=19a76d...
>>>
>>> Modified Files
>>> --------------
>>> CHANGELOG | 2 ++
>>> pgadmin/dlg/dlgTable.cpp | 16 ++++++++++++++--
>>> pgadmin/include/dlg/dlgTable.h | 2 +-
>>> 3 files changed, 17 insertions(+), 3 deletions(-)
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hack(dot)(dot)(dot)(at)postgresql(dot)org)
>>> To make changes to your subscription:http://www.postgresql.org/mailpref/pgadmin-hackers
>> This is quite a crippling bug. I ran into this after recreating a
>> table in PostgreSQL 8.4 by using the reverse engineered SQL in the SQL
>> pane. I did not realize the nonsensical statements further down at
>> first. Like:
>>
>> CREATE CONSTRAINT TRIGGER "RI_ConstraintTrigger_142372"
>> AFTER INSERT
>> ON wuchtel.bet
>> FOR EACH ROW
>> EXECUTE PROCEDURE "RI_FKey_check_ins"();
>>
>> The DDL commands worked - the table was created. But later when I
>> tried to insert data I ran into strange errors:
>> No »pg_constraint«-entry for trigger »RI_ConstraintTrigger_142372«
>> for table »bet2«
>>
>> I am afraid this will make quite a few users trip. I would very much
>> welcome an early release of 1.14.3.
>>
> This bug is not fixed yet.

Not sure which bug it was exactly, but with 1.14.2 (and PostgreSQL 9.1
now) the bug is gone.
Thanks for the good work!

Regards
Erwiin

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-02-27 16:16:38 Re: Re: pgAdmin III commit: Fix constraints handling on the table properties di
Previous Message Guillaume Lelarge 2012-02-27 14:30:38 pgAdmin website commit: Announcing 1.14.2...