Skip site navigation (1) Skip section navigation (2)

Review of: explain / allow collecting row counts without timing info

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Cc: Eric Theise <erictheise(at)gmail(dot)com>
Subject: Review of: explain / allow collecting row counts without timing info
Date: 2012-01-13 17:07:03
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Eric's review follows:

Compiling on Ubuntu 10.04 LTS AMD64 on a GoGrid virtual machine from
2012-01-12 git checkout.

Patch applied fine.

'make check' results in failures when this patch is put into place.

 6 of 128 tests failed.

Here are the relevant failures.

parallel group (2 tests):  create_view create_index
     create_index             ... FAILED
parallel group (9 tests):  create_cast create_aggregate drop_if_exists
typed_table vacuum constraints create_table_like triggers inherit
     inherit                  ... FAILED
parallel group (20 tests):  select_distinct_on btree_index update random
select_distinct select_having namespace delete case hash_index union
select_implicit select_into transactions portals subselect arrays
aggregates join prepared_xacts
     join                     ... FAILED
     aggregates               ... FAILED
parallel group (15 tests):  combocid portals_p2 advisory_lock xmlmap
tsdicts guc functional_deps dependency select_views cluster tsearch
window foreign_data foreign_key bitmapops
     foreign_data             ... FAILED
parallel group (19 tests):  limit prepare copy2 conversion xml plancache
returning temp sequence without_oid with rowtypes truncate polymorphism
domain largeobject rangefuncs alter_table plpgsql
     alter_table              ... FAILED

Josh Berkus
PostgreSQL Experts Inc.


pgsql-hackers by date

Next:From: Robert HaasDate: 2012-01-13 17:08:05
Subject: Re: Disabled features on Hot Standby
Previous:From: Josh BerkusDate: 2012-01-13 16:44:26
Subject: Re: Postgres ReviewFest Patch: URI connection string support for libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group