libpq example doesn't work

From: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: libpq example doesn't work
Date: 2018-06-27 06:29:36
Message-ID: 4E72940DA2BF16479384A86D54D0988A567BA1B0@G01JPEXMBKW04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

When I tried to use libpq, I found that libpq example[1] does not work.
That's because SELECT pg_catlog.set_config() never returns PGRES_COMMAND_OK which is expected,
but actually returns PGRES_TUPLES_OK.

Patch attached.
I changed both src/test/example and document.

[1] https://www.postgresql.org/docs/devel/static/libpq-example.html

(By the way, I'm wondering why these examples are placed under src/test.
They are just examples and not regression tests.)

Best regards,
Takeshi Ideriha

Attachment Content-Type Size
0001-libpq-example-fix.patch application/octet-stream 2.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-06-27 06:33:34 Re: postgresql_fdw doesn't handle defaults correctly
Previous Message Amit Langote 2018-06-27 06:28:47 Re: postgresql_fdw doesn't handle defaults correctly