SSI 2PC coverage

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>
Subject: SSI 2PC coverage
Date: 2011-07-05 17:06:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

[resending after gzip of test patch]

In reviewing the recent fix to 2PC coverage in SSI, I found some
cases which didn't seem to be covered. Dan bit the bullet and came
up with an additional isolation test to rigorously cover all the
permutations, to find *all* 2PC statement orderings which weren't
working right. Because it was so big, he pared out tests which were
redundant, in that they exercised the same code paths and pointed at
the same issues. A patch to add this test is attached. Run against
HEAD it shows the errors. It's kinda big, but I think it's worth

Attached is also a patch to fix those, so that all permutations

I hope that this one be committed for beta3.


Attachment Content-Type Size
ssi-2pc-test.patch.gz application/octet-stream 42.1 KB
ssi-2pc-fix.patch text/plain 5.4 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-07-05 17:13:50 lazy vxid locks, v2
Previous Message Robert Haas 2011-07-05 17:06:22 Re: Range Types, constructors, and the type system