Re: pgAdmin III commit: Install adminpack on user request in frmStatus

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Install adminpack on user request in frmStatus
Date: 2011-04-20 12:47:51
Message-ID: 4DAED5F7.7090700@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 20/04/2011 11:30, Dave Page a écrit :
> On Tue, Apr 19, 2011 at 9:58 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 19/04/2011 12:47, Dave Page a écrit :
>>>
>>> I was thinking more that we shouldn't have a hint in one place, and
>>> offer to fix it in another. We should have the hint, and offer to fix
>>> the problem in all places (frmHint can handle "fix" options iirc - for
>>> example, it can vacuum for you).
>>>
>>
>> Got it :)
>>
>> This patch should fix all the remaining issues, shouldn't it?
>
> Yes, that's more along the lines of what I was expecting. I did spot a typo:
>
> +<p>One your extension is installed, you only need to click on the "Fix"
>
> s/One/Once/
>

Fixed and pushed.

Thanks.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2011-04-20 14:17:52 Re: [pgAdmin III] #299: Crash on table refresh
Previous Message Guillaume Lelarge 2011-04-20 12:47:40 pgAdmin III commit: Use frmHint to fix the addition of adminpack