Re: Disable optimization when in subtransaction

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>, "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: Disable optimization when in subtransaction
Date: 2011-04-04 18:57:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> When I was investigating this report:
> besides providing a straightforward fix here:
> I noted that there was nearby code which needed review, as it
> didn't seem safe when in a subtransaction. Further review
> confirmed this and didn't turn up any other problems in that
> section of code. So, a fix for this overreaching optimization is
> attached. Note that it is a one-line fix except for some
> additional comments to explain the limitation.
> This patch is in addition to and orthogonal to the first patch
> cited above.
> I will add this one to the 9.1 open items list.

I managed to get a one-line patch wrong. Sorry. 2nd try.


Attachment Content-Type Size
ssi-subtransaction-no-optimization-v2.patch text/plain 1.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-04 18:58:31 Re: GUC assign hooks (was Re: wal_buffers = -1 and SIGHUP)
Previous Message Robert Haas 2011-04-04 18:56:25 Re: time table for beta1