Re: Yet another fast GiST build

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Yet another fast GiST build
Date: 2020-09-21 14:19:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 21 сент. 2020 г., в 18:29, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
> It was a conscious decision with incorrect motivation. I was thinking that it will help to reduce number of "false positive" inspecting right pages. But now I see that:
> 1. There should be no such "false positives" that we can avoid
> 2. Valid rightlinks could help to do amcheck verification in future

Well, point number 2 here is invalid. There exist one leaf page p, so that if we start traversing rightlink from p we will reach all leaf pages. But we practically have no means to find this page. This makes rightlinks not very helpful in amcheck for GiST.

But for consistency I think it worth to install them.


Best regards, Andrey Borodin.

Attachment Content-Type Size
0001-Install-rightlinks-on-GiST-pages-in-case-of-sorting-.patch application/octet-stream 1.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-21 14:20:19 Re: Yet another fast GiST build
Previous Message Alvaro Herrera 2020-09-21 13:41:46 Re: Command statistics system (cmdstats)