Skip site navigation (1) Skip section navigation (2)

Re: Allowing multiple concurrent base backups

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allowing multiple concurrent base backups
Date: 2011-01-31 16:29:05
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On 25.01.2011 06:02, Fujii Masao wrote:
> On Tue, Jan 25, 2011 at 6:02 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>> Hmm, perhaps the code would be more readable if instead of the
>> forcePageWrites counter that counts exclusive and non-exclusive backups, and
>> an exclusiveBackup boolean indicating if one of the in-progress backups is
>> an exclusive one, we had a counter that only counts non-exclusive backups,
>> plus a boolean indicating if an exclusive backup is in progress in addition
>> to them.
>> Attached is a patch for that (against master branch, including only xlog.c).
> I read this patch and previous-posted one. Those look good.
> Comments:
> + * do_pg_start_backup is the workhorse of the user-visible pg_stop_backup()
> + * function.
> Typo: s/do_pg_start_backup/do_pg_stop_backup
> It's helpful to explain about this behavior in pg_basebackup.sgml or elsewhere.

Thanks. I've committed this now, fixing that, and hopefully all the 
other issues mentioned in this thread.

   Heikki Linnakangas

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2011-01-31 16:29:56
Subject: Re: Spread checkpoint sync
Previous:From: Tom LaneDate: 2011-01-31 16:25:38
Subject: Re: Add ENCODING option to COPY

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group