Re: top-level DML under CTEs

From: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: top-level DML under CTEs
Date: 2010-10-05 15:29:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2010-10-05 3:37 PM +0300, Hitoshi Harada wrote:
> 2010/10/5 Marko Tiikkaja<marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
>> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
>> patch just a bit and it now passes all regression tests so I can review
>> it. New version attached for documentation purposes.
> Thank you, I didn't notice that commit. In your last patch, the
> snippet to add errhint() and ref/insert sgml is unnecessary since it
> was for INSERT ... VALUES fix.

The patch seems to work for all cases I can think of.

I'm going to mark this one ready for committer.

Marko Tiikkaja

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2010-10-05 15:30:30 Re: Sync Rep at Oct 5
Previous Message Robert Haas 2010-10-05 15:28:57 Re: leaky views, yet again