Re: encode/decode support for base64url

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl>
Subject: Re: encode/decode support for base64url
Date: 2025-09-18 19:19:07
Message-ID: 4CA85654-D598-436F-B7AE-B5ECD2366F8E@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 Sep 2025, at 19:51, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:

> Thank you for updating the patch! I've done additional tests in my
> environment and all test cases passed. One very minor comment is that
> we might want to add 'BASE64URL' to:
>
> /*
> * BASE64
> */

I did that, and polished a few comments which had various version of case on
"base64url". The RFC only mentions it in all lowercase so I went with that
apart from the in the comment mentioned above.

The attached v9 has this and

> Overall, the patch looks good to me. I'll wait for Daniel as he has
> polished this patch and might have some comments or want to take it.

Agreed, I think this is ready to go in. If you want to push it then feel free,
else I'll take care of it tomorrow.

--
Daniel Gustafsson

Attachment Content-Type Size
v9-0001-Add-support-for-base64url-encoding-and-decoding.patch application/octet-stream 14.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-09-18 19:20:29 fix obsolete references to postgres.h in comments
Previous Message Andres Freund 2025-09-18 19:16:21 Re: Updating IPC::Run in CI?