Re: ECPG - Some errno definitions don't match to the manual

From: Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: ECPG - Some errno definitions don't match to the manual
Date: 2010-09-28 04:06:19
Message-ID: 4CA169BB.8070805@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-general

On 2010/09/28 12:40, Alvaro Herrera wrote:
> Excerpts from Satoshi Nagayasu's message of lun sep 27 22:38:44 -0400 2010:
>> On 2010/09/28 10:31, Greg Smith wrote:
>>> If the patch you generated applies to the git version of the repo cleanly, you may be fine for now. The anon-cvs version is mainly intended as a source to get a copy of the source code just to compile or read, not to develop patches against. For that it would be better to switch to git when you get some time to spend on that.
>>
>> So, I have created another patch from git repository.
>> The attached one could be applied to the latest code.
>
> Looking at this patch I cannot but wonder if this should be a table
> instead of a plain list.

What's happen if you run the patch command at top of the repository?

[snaga(at)devwa02 postgresql]$ pwd
/home/snaga/pgsql/repo/postgresql
[snaga(at)devwa02 postgresql]$ patch -p1 < ../ecpg-git.sgml.diff
patching file doc/src/sgml/ecpg.sgml
[snaga(at)devwa02 postgresql]$

or

[snaga(at)devwa02 postgresql]$ git apply --reject ../ecpg-git.sgml.diff
../ecpg-git.sgml.diff:123: trailing whitespace.

Checking patch doc/src/sgml/ecpg.sgml...
Applied patch doc/src/sgml/ecpg.sgml cleanly.
warning: 1 line adds whitespace errors.
[snaga(at)devwa02 postgresql]$

Sorry I'm not familiar with Git yet, but I think above command can
apply the patch.
(I created the patch with the command `git diff'. Is this correct?)

Thanks,
--
NAGAYASU Satoshi <satoshi(dot)nagayasu(at)gmail(dot)com>

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Alvaro Herrera 2010-09-28 05:08:00 Re: ECPG - Some errno definitions don't match to the manual
Previous Message Alvaro Herrera 2010-09-28 03:40:16 Re: ECPG - Some errno definitions don't match to the manual

Browse pgsql-general by date

  From Date Subject
Next Message Craig Ringer 2010-09-28 04:28:24 Re: Preserving order through an inner join
Previous Message Michael Glaesemann 2010-09-28 03:56:32 Re: Deleting orphaned records (not exists is very slow)