Re: pgAdmin III 1.12: Toolbar issue on modern windows

Hi Guillaume,

I tried to reproduce this this issue starting with the update line with
12.0 RC1,
but everthing worked fine from there. So not that many will be affected.
As far as I could estimate your patch fixes this issue. I need to
estimate because
of I don't get I reproduced so that I can't really verify your patch.

Regards Steffen

Am 21.09.2010 21:40, schrieb Guillaume Lelarge:
> Le 21/09/2010 15:56, Guillaume Lelarge a écrit :
>
>> Hi Steffen,
>>
>> Le 21/09/2010 12:12, Steffen Kuhn a écrit :
>>
>>> [...]
>>> today I had had the chance to check this issue on Windows 7 and everything is fine.
>>> As further check I removed the key HKCU\Software\pgAdmin III\frmStatus from the registry of my Vista box
>>> and e evoila everything is fine on Vista.
>>> I've no idea where this is coming from; may be this comes from my version beeing upgraded from the betas in combination with a missing
>>> perspective update for this case - but I just guessing.
>>>
>>>
>> We have a setting telling the size of some component
>> (FRMSTATUS_PERSPECTIVE_VER in this case). The setting depended on the
>> release number you installed. One reason could be that, since the git
>> migration, the release "number" is not updated. Previously, we used the
>> SVN commit id, which increments automatically. Maybe I forgot to do it
>> last time I changed the setting. According to GIT, it doesn't seem to be
>> happening. Probably an effect of using dev releases. Can't tell you more
>> right now.
>>
>>
> Well, I still think there is an issue here. We used the VerFromRev()
> function before when we were using svn, but its use right now make every
> parameter get the name "Perspective-" instead of "Perspective-<id>".
>
> Patch attached.
>
>
>