Re: Bug: recent files reset

Le 25/03/2010 23:15, Guillaume Lelarge a écrit :
> Le 21/03/2010 08:20, Guillaume Lelarge a écrit :
>> Le 15/03/2010 23:33, Guillaume Lelarge a écrit :
>>> Le 15/03/2010 23:16, Josh Berkus a écrit :
>>>> Version: 1.10.1
>>>> Platform: OSX 10.5
>>>> Severity: Annoyance
>>>> Reproduceable: sometimes
>>>> Description:
>>>>
>>>> 1) have a bunch of query windows for saved SQL files open (call them
>>>> files 1,2,3,4,5 and 6 in order in which they are opened).
>>>> 2) save file #1 and close it.
>>>> 3) In another, the query window for #5 pick file #1 from the "recent
>>>> files" list in the menu.
>>>> 4) File #2 will actually open.
>>>>
>>>> What happened: until File #1 was closed and saved, it was at the bottom
>>>> of the recent files list. Closing it and saving it will have bumped it
>>>> up to the top of the recent files list. However, the query window for
>>>> query #5 will not show this change until *after* you attempt to access a
>>>> file from that list, which is why it gives you the wrong file.
>>>>
>>>
>>> You're right. I added a ticket on our trac system
>>> (http://code.pgadmin.org/trac/ticket/149), so that we remember to work
>>> on it ASAP.
>>>
>>>
>>
>> Took a look at it today. The only way to get rid of it easily would be
>> to update the file only when we quit the query tool. Which means that a
>> window will first see the files that were recorded in the history, will
>> update its menu (but not the prefs file) when the user opens files,
>> won't get updates from other query window, and will push its history in
>> the prefs file when the user closes the query window. Whichs also means
>> that when a user quits pgAdmin, only one history will remain, the one of
>> the last query tool closed.
>>
>> Comments?
>>
>
> No comments on that one?
>

Patch attached.

I found a better way to fix it, which allows many great things for 1.12.
Anyways, this fix uses this method: for each change on a query window,
all the other query windows are notified of the change and reload the
file. So, they all share the same informations.

Moreover, we had the same issue with the favourites and the macros
files. The patch attached fixes that too.

I don't commit it right now. Dave, can you get a look at it? is the
patch good to go? Thanks.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com