Re: pg_stop_backup does not complete

On 2/24/10 5:36 PM, Greg Smith wrote:
> gsmith=# select pg_stop_backup();
> NOTICE: pg_stop_backup cleanup done, waiting for required segments to
> archive
> WARNING: pg_stop_backup still waiting for all required segments to
> archive (60 seconds elapsed)
> HINT: Confirm your archive_command is executing successfully.
> pg_stop_backup can be aborted safely, but the resulting backup will not
> be usable.
> ^CCancel request sent
> ERROR: canceling statement due to user request

This looks really good, thanks!

> Does this solve the logging side of this? You can still make a case for
> a more forceful pg_stop_backup, this seems to at least remove much of
> the mystery and frustration from the whole exercise. This patch plus a
> little documentation suggesting how to recover from this issue might be
> enough.

Yeah, the concern is user-friendliness. As Simon points out, allowing
pg_stop_backup to abort would have other unexpected-results issues.

--Josh Berkus