Re: [PATCH] Provide rowcount for utility SELECTs

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2010-02-12 18:55:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Robert Haas írta:
> On Fri, Feb 12, 2010 at 1:22 PM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>> Robert Haas írta:
>>> On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>>>> I added a small change to protocol.sgml for the
>>>> "CommandComplete" message describing the change.
>>>> Is it enough?
>>> Ah, I didn't even see that that section needed to be updated. Good
>>> catch. I'd suggest the following wording:
>>> For a <command>SELECT</command> or <command>CREATE TABLE AS</command>
>>> command, the tag is SELECT rows... [and the rest as you have it]
>>> We should probably also retitle that section from "Retrieving Result
>>> Information for Other Commands" to "Retrieving Other Result
>>> Information" and adjust the text of the opening sentence similarly.
>>> Also I think you need to update the docs for PQcmdtuples to mention
>>> that it not works for SELECT and CTAS.
>> Ok, I will update libpq.sgml where this section resides.
>> What's a CTA, btw? Do you mean CTE, a.k.a. "Common Table Expression"?

Okay, new patch is attached. Please read the docs changes, and comment.

Zoltán Böszörményi

Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH

Attachment Content-Type Size
6-pg85-provide-rowcount-for-utility-select-7-ctxdiff.patch text/x-patch 9.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-02-12 19:31:48 Re: logtrigger issue in PostgreSQL HEAD
Previous Message Robert Haas 2010-02-12 18:38:11 Re: [PATCH] Provide rowcount for utility SELECTs