Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Provide rowcount for utility SELECTs

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Alvaro Herrera <alvherre(at)commandprompt(dot)com>,Peter Eisentraut <peter_e(at)gmx(dot)net>,Hans-Juergen Schoenig <hs(at)cybertec(dot)at>,Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2010-02-02 09:03:21
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Robert Haas írta:
> 2010/1/12 Boszormenyi Zoltan <zb(at)cybertec(dot)at>:
>> Tom Lane írta:
>>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>>> But it would be broken in very obvious ways, no?  It's not like it would
>>>> be silently broken and thus escape testing ...
>>> Well, if we wanted to adopt that approach, we should add the count to
>>> *all* SELECT tags not just a small subset.  As the patch stands it
>>> seems entirely possible that a breakage would escape immediate notice.
>> Can you give me an example that would return
>> plain "SELECT" after my new patch? I added
>> one more change to the patch, is it enough to return
>> "SELECT N" in every case now?
> I just tested this, so I can say definitely: no.  I hacked psql with
> the attached patch, and if you just do a plain old SELECT * FROM
> table, you get back only SELECT, not SELECT N.
> ...Robert

Thanks for testing it, with the attached patch your test case also
returns SELECT N.

Best regards,
Zoltán Böszörményi

Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH

Attachment: 6-pg85-provide-rowcount-for-utility-select-3-ctxdiff.patch
Description: text/x-patch (4.8 KB)

In response to


pgsql-hackers by date

Next:From: Albe LaurenzDate: 2010-02-02 09:13:42
Subject: Re: PG 9.0 and standard_conforming_strings
Previous:From: Jesper KroghDate: 2010-02-02 06:03:35
Subject: Re: Make TOAST_TUPLES_PER_PAGE configurable per table.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group