Skip site navigation (1) Skip section navigation (2)

Re: Streaming replication, and walsender during recovery

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Streaming replication, and walsender during recovery
Date: 2010-01-28 10:43:17
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Fujii Masao wrote:
> On Thu, Jan 28, 2010 at 4:47 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> I think there's a race condition at the end of recovery. When the
>> shutdown checkpoint is written, with new TLI, doesn't a cascading
>> walsender try to send that to the standby as soon as it's flushed to
>> disk? But it won't find it in the WAL segment with the old TLI that it's
>> reading.
> Right. But I don't think that such a shutdown checkpoint record is worth
> being sent by a cascading walsender. I think that such a walsender has
> only to exit without regard to the WAL segment with the new TLI.
>> Also, when segments are restored from the archive, using
>> restore_command, the cascading walsender won't find them because they're
>> not written in pg_xlog like normal WAL segments.
> Yeah, I need to adjust my approach to the recent 'xlog-refactor' change.
> The archived file needs to be restored without a name change, and remain
> in pg_xlog until the bgwriter will have recycled it.

I guess you could just say that it's working as designed, and WAL files
restored from archive can't be streamed. Presumably the cascaded slave
can find them in the archive too. But it is pretty weird, doesn't feel

This reminds me of something I've been pondering anyway. Currently,
restore_command copies the restored WAL segment as pg_xlog/RECOVERYXLOG
instead of the usual 00000... filename. That avoids overwriting any
pre-existing WAL segments in pg_xlog, which may still contain useful
data. Using the same filename over and over also means that we don't
need to worry about deleting old log files during archive recovery.

The downside in standby mode is that once standby has restored segment X
from archive, and it's restarted, it must find X in the archive again or
it won't be able to start up. The archive better be a directory on the
same host.

Streaming Replication, however, took another approach. It does overwrite
any existing files in pg_xlog, we do need to worry about deleting old
files, and if the master goes down, we can always find files we've
already streamed in pg_xlog, so the standby can recover even if the
master can't be contacted anymore.

That's a bit inconsistent, and causes the problem that a cascading
walsender won't find the files restored from archive.

How about restoring/streaming files to a new directory, say
pg_xlog/restored/, with the real filenames? At least in standby_mode,
probably best to keep the current behavior in PITR. That would feel more
clean, you could easily tell apart files originating from the server
itself and those copied from the master.

> But that change would make the xlog.c even more complicated. Should we
> postpone the 'cascading walsender' feature into v9.1, and, in v9.0, just
> forbid walsender to be started during recovery?

That's certainly the simplest solution...

  Heikki Linnakangas

In response to


pgsql-hackers by date

Next:From: Boszormenyi ZoltanDate: 2010-01-28 11:11:56
Subject: Re: CommitFest status summary 2010-01-27
Previous:From: Fujii MasaoDate: 2010-01-28 10:22:36
Subject: Re: Streaming replication, and walsender during recovery

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group