Re: Ticket 117: Explain Buffers

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Ticket 117: Explain Buffers
Date: 2010-01-26 09:18:14
Message-ID: 4B5EB356.4030501@lelarge.info
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 26/01/2010 04:13, Euler Taveira de Oliveira a écrit :
> Guillaume Lelarge escreveu:
>> New patch attached.
>>
> Nice job. But there are just a few gripes about your patch: (i) it doesn't
> disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't
> disable the EXPLAIN ANALYZE menu when the query is running, and (iii) there is
> a bug when the BUFFERS option is enabled and you close and open the query tool
> again (the EXPLAIN menu turns enabled instead of disabled).
>
> The attached patch (on the top of your patch) addresses all of these problems.
>

Thanks a lot for your help. I added your patch, here is the new complete
patch.

Seems good to me. Any more comments before I apply it?

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
ticket117_v3.patch text/x-patch 9.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2010-01-26 09:19:52 [pgAdmin III] #132: Use one of the new format for the graphical EXPLAIN
Previous Message Euler Taveira de Oliveira 2010-01-26 03:13:12 Re: Ticket 117: Explain Buffers