Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] "could not reattach to shared memory" on Windows

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] "could not reattach to shared memory" on Windows
Date: 2009-07-14 16:31:13
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Since this fixes a very annoying bug present in older versions, I think
>> this should be backpatched all the way back to 8.2.
> Agreed, but first we need some evidence that it actually fixes the
> problem.  How can we acquire such evidence?

Apply to CVS HEAD and have people test it. I wouldn'αΊ— be opposed to
back-patching to 8.4 where it would receive more testing in real life.
If we're really uneasy about it, provide a switch to turn it off if it
causes problems.

>> - please use ereport() instead of elog() for error messages
> This is only appropriate if they're user-facing messages, which probably
> errors in this area are not ...

Heh, that's what we hope :-).

  Heikki Linnakangas

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2009-07-14 16:31:34
Previous:From: Stefan KaltenbrunnerDate: 2009-07-14 16:21:05
Subject: Re: Launching

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group