Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

From: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: 2025-05-14 15:33:18
Message-ID: 4987DD3D-FE66-4E6B-92DF-F02C6F281A03@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 May 2025, at 11:00 PM, David E. Wheeler <david(at)justatheory(dot)com> wrote:
>
> On May 13, 2025, at 16:24, Florents Tselai <florents(dot)tselai(at)gmail(dot)com> wrote:
>
>> As Robert said—and I agree—renaming the existing _tz family would be more trouble than it’s worth, given the need for deprecations, migration paths, etc. If we were designing this today, suffixes like _stable or _volatile might have been more appropriate, but at this point, we’re better off staying consistent with the _tz family.
>
> I get the pragmatism, and don’t want to over-bike-shed, but what a wart to live with. [I just went back and re-read Robert’s post, and didn’t realize he used exactly the same expression!] Would it really be too effortful to create _stable or _volatile functions and leave the _tz functions as a sort of legacy?

Thinking about it a second time, you may be right.
Especially if more people are interested in adding even more methods there.

Here’s a patch just merging the latest changes in the jsonpath tooling;
no substantial changes to v1; mainly for CFbot to pick this up.

Attachment Content-Type Size
v2-0001-Rebase-latest-changes.-jsonpath_scan.l-white-spac.patch application/octet-stream 43.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jafri, Nazneen 2025-05-14 15:38:03 PostgreSQL 18 Beta 1 io_max_concurrency
Previous Message Andrei Lepikhov 2025-05-14 10:50:46 Re: Incremental Sort Cost Estimation Instability