Re: PATCH: Column Level Privileges

Hi Dave,
> Couple of minor issues/questions:
>
> - Why didn't you derive the dialog from dlgSecurityProperty? I assume
> it would have been too messy as it's already derived from
> dlgTypeProperty?
dlgSecurityProperty and dlgTypeProperty both are derived from dlgPropery.
If we derive the dlgColumn from both of them, it will leads to the
famous Diamond problem.
We can avoid this problem by multiple inheritance using virtual base class.
And hence, it will increase the complexity. :(
> - As a general rule, we disable controls not relevant to a particular
> version of Postgres. We should do the same with this tab - disable the
> controls rather than hide them on servers < 8.4.
sure.
> - Can we lose the comment above the column permissions in the reverse
> engineered SQL please? We don't add similar ones for other additional
> queries so we shouldn't here (though perhaps in the future we might
> add such comments everywhere that is appropriate).
Sure.
> - Not just an issue with your code, but also the existing privilege
> tabs - could you please tweak the column sizes of the list control
> such that the headers can be read by default?
sure.
> Thanks!
>
I will update you as soon as possible.
--
Thanks & Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com